Merged
Conversation
…/autobuild into FailedTestBriefLog_2_merged # Conflicts: # common/prettify.pm # scoreboard.pl
Failed Test Brief Log
Bug fix for Failed Test report
…moci/autobuild into FailedTestBriefLog_2_merged # Conflicts: # common/prettify.pm
…ailedTestBriefLog_2_merged
…nto FailedTestBriefLog_2_merged # Conflicts: # common/prettify.pm # scoreboard.pl
…ailedTestBriefLog_2_merged
common/prettify.pm
Outdated
|
|
||
| if (!$skip_failed_test_logs) { | ||
| push @{$self->{OUTPUT}}, new Prettify::Failed_Tests_HTML ($basename, $buildname, $rev_link, $log_prefix); #Must be 4, if used | ||
| push @{$self->{OUTPUT}}, new Prettify::Failed_Tests_HTML ($basename, $buildname, $self->{FAILED_TESTS}, $rev_link, $log_prefix); #Must be 4, if used |
There was a problem hiding this comment.
should this comment be changed?
Contributor
Author
There was a problem hiding this comment.
There is logic that relies on this being #4 - similar to other reports above
There was a problem hiding this comment.
Maybe make the comment more clear. I assumed it meant that it needed 4 variables passed to be used.
Contributor
Author
There was a problem hiding this comment.
I made it more clear, and there is also a context right above, which makes it even more understandable:
@{$self->{OUTPUT}} =
(
new Prettify::Full_HTML ($basename), #Must be at 0
new Prettify::Brief_HTML ($basename),
new Prettify::Totals_HTML ($basename), #Must be at 2
new Prettify::Config_HTML ($basename), #Must be at 3
);
ClaytonCalabrese
suggested changes
Feb 26, 2021
ClaytonCalabrese
left a comment
There was a problem hiding this comment.
Only thing I see left to deal with is clarify the comment. Otherwise looks good.
ClaytonCalabrese
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.